Zadanie #2675
Zadanie #2664: Zbiorcze podsumowanie zadań po audycie WCAG
Zgrupowanie kontrolek filtrowania w fieldset
| Status: | Zamknięty | Start date: | 2021-09-28 | |
|---|---|---|---|---|
| Priority: | Normalny | Due date: | ||
| Assignee: | - | % Done: | 100% | |
| Category: | - | Spent time: | - | |
| Target version: | - | |||
| Developer: | Marcin Suda | Rewizja rozwiązania: | ||
| Tester: | Tomasz Lewandowski | Rewizja testów: |
Description
Na stronie http://agro.icm.edu.pl/agro/browse/journals
Brak programistycznego powiązania etykiet:
- tytuł
- pełne teksty
- wydawca
Brak zdefiniowanego fieldseta z legendą opisujący charakter dla w/w pól.
<span class="filter-label">
<span>Tytuł</span>
<input title="Wpisz całe wyrażenie lub fragment zakończony * dla
lepszych rezultatów, np. mechani*" id="EQUALS_names" name="EQUALS_names" type="text"
value="" maxlength="60" onkeypress="return onEnterDoRegularFilter(event,this.form);">
</span>
History
#1 Updated by Tomasz Blazejczyk over 2 years ago
- Assignee changed from Tomasz Blazejczyk to Marcin Suda
- Developer Marcin Suda added
#2 Updated by Marcin Suda over 2 years ago
- Status changed from Nowy to Testowanie
- Assignee changed from Marcin Suda to Tomasz Lewandowski
Had some trouble getting the labels to work, it'd be appreciated to check if everything's correct from the programming perspective
#3 Updated by Tomasz Lewandowski over 2 years ago
- File After.jpg added
- File Before.jpg added
- Status changed from Testowanie to W toku
- Assignee changed from Tomasz Lewandowski to Marcin Suda
- % Done changed from 0 to 80
Fieldset was added grouping together three spans cointaining filters with <labels> respectively: Tytuł, Pełne teksty and Wydawca.
Fieldset has a <legend> element containing descriptive text "Filtry:". The text matches the logic of the site and groups filters in accord with their functionality.
"Before.jpg" and "After.jpg" added for clarity.
Applied changes in my opinion fulfill recommendation received from external wcag auditors.
Two things are still left for consideration though:
1.) Alphabetical filters right below the fieldset also seem to fall under description of "Filters". Maybe we should include them into the fieldset as well?
1.1.) If they should not be included into fieldset because they're from technical point of view rather links than fields, maybe we should define their own container labeled "Alphabetical Filters" or suchlike.
2.) Alphabetical filters have decription "Wyświetl tylko zawierające: [letter sequence]". This should be changed to "Wyświetl tylko rozpoczynające się na: [letter sequence]", as the former better fits what they actually do.
#4 Updated by Marcin Suda over 2 years ago
- Status changed from W toku to Testowanie
- Assignee changed from Marcin Suda to Tomasz Lewandowski
I've changed the <fieldset> to include the alphabetical filters - after some thought, I found no reason to exclude them. The link titles were changed.
#5 Updated by Tomasz Lewandowski over 2 years ago
- Status changed from Testowanie to Rozwiązany
- Assignee deleted (
Tomasz Lewandowski) - % Done changed from 80 to 100
everything fine
#6 Updated by Tomasz Lewandowski over 2 years ago
- Status changed from Rozwiązany to Zamknięty